Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ScaleDownLimit as health state for HPA #343

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: add ScaleDownLimit as health state for HPA #343

merged 1 commit into from
Nov 2, 2021

Conversation

harikrongali
Copy link
Contributor

@harikrongali harikrongali commented Oct 28, 2021 •
edited
Loading

@harikrongali harikrongali requested a review from alexmt October 28, 2021 01:53
@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #343 (456dafe) into master (27374da) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   49.40%   49.42%   +0.01%     
==========================================
  Files          41       41              
  Lines        3297     3298       +1     
==========================================
+ Hits         1629     1630       +1     
  Misses       1509     1509              
  Partials      159      159
Impacted Files Coverage Δ
pkg/health/health_hpa.go 83.11% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27374da...456dafe. Read the comment docs.

@harikrongali harikrongali changed the title Add ScaleDownLimit as health state for HPA fix: add ScaleDownLimit as health state for HPA Oct 28, 2021
@harikrongali
fix: Add ScaleDownLimit as health state for HPA
456dafe 
Signed-off-by: hari rongali <hari_rongali@intuit.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mayzhang2000
mayzhang2000 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sahilbadla
sahilbadla approved these changes Oct 28, 2021
View reviewed changes
Copy link

@sahilbadla sahilbadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexmt
alexmt approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@alexmt alexmt merged commit 2565df3 into argoproj:master Nov 2, 2021
alexmt pushed a commit that referenced this pull request Nov 19, 2021
@harikrongali @alexmt
fix: Add ScaleDownLimit as health state for HPA (#343)
2258a21 
Signed-off-by: hari rongali <hari_rongali@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayzhang2000 mayzhang2000 mayzhang2000 approved these changes

@sahilbadla sahilbadla sahilbadla approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ScaleDownLimit as health state for HPA
4 participants
@harikrongali @alexmt @sahilbadla @mayzhang2000