Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default protocol to subset of ports if it is empty #347

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ahalay
Copy link
Contributor

@ahalay ahalay commented Nov 4, 2021

Signed-off-by: Roman Rudenko 3kmnazapad@gmail.com

Fixes argoproj/argo-cd#6300
by adding default protocol to subset of ports if it is not defined before sorting

Signed-off-by: Roman Rudenko <3kmnazapad@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @ahalay ! Sorry for long response - we did not notice the PR

@alexmt alexmt merged commit b0c5e00 into argoproj:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoints diff confused by ports sorting
2 participants