Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(server): use server side dry run in case if it is server side apply" #547

Closed

Conversation

pasha-codefresh
Copy link
Member

Reverts #546

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pasha-codefresh
Copy link
Member Author

Снимок экрана 2023-10-31 в 18 16 54 This issue started to appear after this change

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a5648e) 54.70% compared to head (b990546) 54.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   54.70%   54.63%   -0.07%     
==========================================
  Files          41       41              
  Lines        4645     4638       -7     
==========================================
- Hits         2541     2534       -7     
  Misses       1908     1908              
  Partials      196      196              
Files Coverage Δ
pkg/sync/sync_context.go 74.07% <100.00%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants