Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect and report cluster connection errors #559

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: detect and report cluster connection errors #559

wants to merge 7 commits into from

Commits on May 9, 2024

  1. bug: Argo CD should update the correct cluster connectivity status 

    Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c2f4b02 View commit details
    Browse the repository at this point in the history

  2. Use lock before updating connection status 

    Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    24d1408 View commit details
    Browse the repository at this point in the history

  3. update the connection status periodically using watch errors 

    Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4a32ce8 View commit details
    Browse the repository at this point in the history

  4. use context while updating cluster status 

    Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2b291f7 View commit details
    Browse the repository at this point in the history

  5. Address review comments 

    - Refactor the the clusterConnectionService to use locks before reading the status
- Rename the function that monitors the cluster connection status
- Fix typo

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7f1b996 View commit details
    Browse the repository at this point in the history

  6. Update the cluster connection interval as configurable 

    Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c129232 View commit details
    Browse the repository at this point in the history

  7. Retry reaching the server if there are transient errors 

    Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
    @chetan-rns
    chetan-rns committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b3e1c67 View commit details
    Browse the repository at this point in the history