-
Notifications
You must be signed in to change notification settings - Fork 276
fix: pod with a restart policy of Never or OnFailure stuck at 'Progressing' (#15317) #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 54.26% 53.68% -0.58%
==========================================
Files 64 64
Lines 6164 6480 +316
==========================================
+ Hits 3345 3479 +134
- Misses 2549 2725 +176
- Partials 270 276 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This looks like a good approach to the problem. |
The pod manifest needs the following to pass the tests:
|
pkg/health/testdata/pod-running-restart-never-with-ignore-annotation.yaml
Fixed
Show fixed
Hide fixed
pkg/health/testdata/pod-running-restart-never-with-ignore-annotation.yaml
Fixed
Show fixed
Hide fixed
@drewhemm I have made the changes you suggested to get a Quality Gate pass |
Cool, looks like the last blocking issue is the commit sign off. |
444a326
to
84a1039
Compare
A non-blocking issue has been flagged by SonarQube, probably best to resolve it as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. left nits.
Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
…sses the checks of the Quality Gate Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
improve code readability Co-authored-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
|
This implementation extends the health condition check for pods.
Previously the assumption was that Pods with restart policy of Never or OnFailure are hooks with a finite life, these were considered as Progressing instead of Healthy. However, this logic does not apply when the pod is managed by an operator (e.g., Flink operator) and therefore has a restart policy of Never.
We introduce a new annotation which existence is checked when the pod is Running, that allows for skipping this logic on restart policy.