This repository was archived by the owner on Nov 8, 2025. It is now read-only.
fix: server-side diff shows refresh/hydrate annotations #737
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 54.26% 47.51% -6.76%
==========================================
Files 64 64
Lines 6164 6567 +403
==========================================
- Hits 3345 3120 -225
- Misses 2549 3190 +641
+ Partials 270 257 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leoluz
approved these changes
Jun 17, 2025
RoelofKuijpers
pushed a commit
to RoelofKuijpers/gitops-engine
that referenced
this pull request
Jul 29, 2025
Signed-off-by: Peter Jiang <peterjiang823@gmail.com> Signed-off-by: Roelof Kuijpers <roelof.kuijpers@energyessentials.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes argoproj/argo-cd#23436 a bug where ephemeral annotations like refresh/hydrate show in the diff despite being in ignoreResourceUpdates
This could happen in instances with large number of apps that need to be refreshed as the diff calculation process is in progress, the annotations are added to live resource, but aren't removed quickly enough before diff calculation finishes. Adding another Normalize before diff calculation ends fixes the problem