fix: server-side diff shows duplicate containerPorts #791
Conversation
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| labels: | ||
| app: test-app | ||
| spec: | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium test
| app: test-app | ||
| spec: | ||
| containers: | ||
| - name: nginx |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
| name: https | ||
| - containerPort: 8080 | ||
| name: metrics | ||
| - name: sidecar |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
| labels: | ||
| app: test-app | ||
| spec: | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium test
| app: test-app | ||
| spec: | ||
| containers: | ||
| - name: nginx |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
| terminationMessagePath: /dev/termination-log | ||
| terminationMessagePolicy: File | ||
| imagePullPolicy: IfNotPresent | ||
| - name: sidecar |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 54.26% 47.63% -6.63%
==========================================
Files 64 64
Lines 6164 6604 +440
==========================================
- Hits 3345 3146 -199
- Misses 2549 3201 +652
+ Partials 270 257 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Qualiy failures are from test failes |
3 participants
Need to make this same change argoproj/argo-cd#24785
in order to cherry-pick for argo-cd v3.2