feat: Adding a new version of the PagerDuty integration which uses Events API v2 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricTendian
force-pushed
the
pagerduty-v2
branch
2 times, most recently
from
c04d114 to
7347b12
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 52.90% 53.88% +0.97%
==========================================
Files 33 34 +1
Lines 2807 2938 +131
==========================================
+ Hits 1485 1583 +98
- Misses 1101 1128 +27
- Partials 221 227 +6
☔ View full report in Codecov by Sentry. |
EricTendian
force-pushed
the
pagerduty-v2
branch
2 times, most recently
from
223941c to
3076045
Compare
|
Hey @EricTendian , i think we need move with idea to create it as new integration and not break existing one |
EricTendian
force-pushed
the
pagerduty-v2
branch
from
3076045 to
8ad458c
Compare
EricTendian
changed the title
|
@pasha-codefresh I finally got around to updating this, take a look and let me know if that is more what you're looking for. |
EricTendian
force-pushed
the
pagerduty-v2
branch
from
ed7a0b9 to
f234de7
Compare
docs/services/pagerduty_v2.md
Outdated
| data: | ||
| template.rollout-aborted: | | ||
| message: Rollout {{.rollout.metadata.name}} is aborted. | ||
| pagerduty: |
There was a problem hiding this comment.
Should this be pagerdutyv2?
There was a problem hiding this comment.
Good catch! Fixed.
EricTendian
force-pushed
the
pagerduty-v2
branch
from
f234de7 to
0291e69
Compare
|
Thank you @EricTendian for working on this. I'm looking forward to this capability once it is released. |
zachaller
approved these changes
May 8, 2023
Signed-off-by: Eric Tendian <erictendian@gmail.com>
mayzhang2000
pushed a commit
that referenced
this pull request
May 9, 2023
Signed-off-by: Eric Tendian <erictendian@gmail.com>
13 tasks
zachaller
added a commit
that referenced
this pull request
Jul 12, 2023
* self-service from event * chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#175) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * feat: Adding new PagerDuty integration based on Events API v2 (#105) Signed-off-by: Eric Tendian <erictendian@gmail.com> * self-service from event * self-service from event * self-service from event * self-service from event * self-service from event * clean up factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * better caching * better caching * refactor Signed-off-by: zachaller <zachaller@users.noreply.github.com> * unused Signed-off-by: zachaller <zachaller@users.noreply.github.com> * lint Signed-off-by: zachaller <zachaller@users.noreply.github.com> * bump ci Signed-off-by: zachaller <zachaller@users.noreply.github.com> * small fixes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change log line Signed-off-by: zachaller <zachaller@users.noreply.github.com> * update tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add godoc Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix error by going back to non namespace support Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix log Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve log on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Eric Tendian <erictendian@gmail.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: May Zhang <may_zhang@intuit.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Eric Tendian <erictendian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new version of the PagerDuty service using the Events API v2 instead of the Incident Creation API. The previous API was not meant for use by automation, whereas the Events API matches existing patterns for how to trigger events/incidents in PagerDuty with an integration. I've added docs to note the new configuration.
To avoid a breaking change, this has a service name of
pagerdutyv2instead ofpagerduty.Fixes #89.
Signed-off-by: Eric Tendian <erictendian[at]gmail.com>