feat: support session tokens in S3 client #596
Conversation
hittingray
force-pushed
the
feat-session-tokens
branch
from
50a23dd
to
b14f365
Compare
|
I pretty much duplicated a test for the new ephemeral credentials which looks like it's failing the duplicated code quality gate. I've just pushed up a new commit which minimises the number of options checked in the test. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@alexmt @crenshaw-dev @sarabala1979 could one of you also please help review and merge this? |
@isubasinghe Yep, it's been tested e2e. We are currently running the fork of Argo Workflows I have in argoproj/argo-workflows#12467 and it works correctly. |
This comment was marked as spam.
This comment was marked as spam.
|
This is blocked on the two CI checks which don't seem to have run. They don't seem to run for other changes too. |
|
Is there a maintainer who would be able to kick off the builds? I don't believe I have permission to |
|
Try rebase and push again, that sounds trigger it
…On Tue, 25 Jun 2024, 06:46 Raymond, ***@***.***> wrote:
Is there a maintainer who would be able to kick off the builds? I don't
believe I have permission to
—
Reply to this email directly, view it on GitHub
<#596 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACELYCBKOGFJM474GK45YDZJD725AVCNFSM6AAAAABBMFWBGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGAZDOOBWGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Signed-off-by: Raymond Chow <rchow@atlassian.com>
hittingray
force-pushed
the
feat-session-tokens
branch
from
b14f365
to
2773969
Compare
|
Still the same. I had tried this before and it still requires workflow approval from a maintainer. |
|
The rules in this repo are not the same as in the main repositories, I've set it running for you |
agilgur5
changed the title
This PR adds support for the S3 client to use ephemeral IAM credentials (e.g. an access/secret key pair + session token obtain through an assume role operation) or to use the new S3 access grants feature.
This is a pre-requisite to argoproj/argo-workflows#5446
The relevant PR in Argo Workflows is here: argoproj/argo-workflows#12467
I found the contributing guidelines for Argo Workflows, but couldn't find anything for this specific repo, so please let me know if anything is missing. Thank you!