feat(build): add build number #109
Conversation
gregberge
force-pushed
the
wip-builds-number
branch
2 times, most recently
from
78911c8 to
a66a817
Compare
gregberge
force-pushed
the
wip-builds-number
branch
from
a66a817 to
46768bc
Compare
| await knex.raw(` | ||
| UPDATE builds SET number = numbers.number | ||
| FROM ( | ||
| SELECT id, row_number() OVER (PARTITION BY "repositoryId" ORDER BY id) AS number |
There was a problem hiding this comment.
Looks like it's working 👍
src/server/models/Build.js
Outdated
| @@ -58,6 +59,16 @@ export default class Build extends BaseModel { | |||
| } | |||
| } | |||
|
|
|||
| $toDatabaseJson() { | |||
| const attributes = super.$toDatabaseJson() | |||
| attributes.number = this.$knex().raw( | |||
There was a problem hiding this comment.
Does it work if we do a patch on the build?
gregberge
force-pushed
the
wip-builds-number
branch
3 times, most recently
from
c811966 to
0726b0d
Compare
| knex = connect('test') | ||
| await knex.migrate.latest() | ||
| await truncateAll(knex) | ||
| beforeAll(() => { |
There was a problem hiding this comment.
It's going to be much better 👍 .
Runs a function before any of the tests in this file run
I'm wondering if we could make it global.
src/server/models/Build.test.js
Outdated
| @@ -13,6 +13,24 @@ const baseData = { | |||
| describe('models/Build', () => { | |||
| useDatabase() | |||
|
|
|||
| describe('create build', () => { | |||
| it('should add a build number', async () => { | |||
| const build = await factory.create('Build') | |||
src/server/models/Build.test.js
Outdated
| expect(build.number).toBe(1) | ||
| await build.$query().patch({ jobStatus: 'complete' }) | ||
| expect(build.jobStatus).toBe('complete') | ||
| }) |
There was a problem hiding this comment.
expect(build.number).toBe(1)
There was a problem hiding this comment.
A reload might be good too.
| // Process on exit and signals. | ||
| process.on('exit', () => { | ||
| terminator() | ||
| log('Node server stopped.') | ||
| }); | ||
|
|
||
| // Removed 'SIGPIPE' from the list - bugz 852598. |
There was a problem hiding this comment.
Looks like the issue was fixed nodejs/node-v0.x-archive#2286.
| log('Shutdown server gracefully...') | ||
| log(`${SHUTDOWN_TIMEOUT}ms before killing it.`) | ||
| callbacks.forEach(callback => callback()) | ||
| setTimeout(() => terminator(), SHUTDOWN_TIMEOUT) |
There was a problem hiding this comment.
In an ideal world, we would clear this timeout once the callbacks complete.
Right now, I'm expecting the program to always wait 3s before closing, with no feedback regarding if it was clean or not.
gregberge
force-pushed
the
wip-builds-number
branch
2 times, most recently
from
31ac82c to
2fd7bf6
Compare
gregberge
force-pushed
the
wip-builds-number
branch
from
2fd7bf6 to
42a6b82
Compare
Closes #106