New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix types resolution for expect-puppeteer #599

Merged

gregberge merged 1 commit into argos-ci:main from mulekick:my_branch

Oct 10, 2024

Contributor

mulekick commented Oct 7, 2024

Summary

This pull request contains :

A refactoring of the expect-puppeteer types so that types resolution for the puppeteer matchers work in Typescript (issue 598).
Additional type assertions on the Error objects in the tests to eliminate any types and comply to @typescript-eslint/recommended.
A few upgrades of deprecated methods on the puppeteer API (see resetBrowser.test.ts).
An update on the main README to reflect the changes.

Test plan

No breaking changes or regressions should occur since the implementation was left untouched, only types declarations were changed.
Test suite passes 100%.

When testing the minimal repo with the following dependencies :

Typescript complains, types resolution does not work

Then changing dependencies to point to my fork, adding @types/jest and npm i :

Typescript is ok and types resolution works again 👍


          fix types resolution for expect-puppeteer

gregberge merged commit 37e3271 into argos-ci:main

3 checks passed

gregberge mentioned this pull request

Types resolution fails for expect-puppeteer matchers #598

Closed

Member

gregberge commented Oct 10, 2024

Great, thanks for that!

mulekick deleted the my_branch branch

October 10, 2024 17:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet