Skip to content

[ewasm] Terminate on out-of-bounds access in EwasmInterpreter #10135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chriseth merged 1 commit into from
Oct 29, 2020
Merged

[ewasm] Terminate on out-of-bounds access in EwasmInterpreter #10135

chriseth merged 1 commit into from
Oct 29, 2020

Conversation

@axic
Copy link
Contributor

@axic axic commented Oct 28, 2020

No test we have is affected by this apparently.

@axic axic requested review from aarlt, cameel and chriseth October 28, 2020 14:53
@axic axic marked this pull request as draft October 28, 2020 14:56
@axic axic marked this pull request as ready for review October 28, 2020 15:00
@axic
Copy link
Contributor Author

axic commented Oct 28, 2020

Should squash before merge.

axic
axic commented Oct 28, 2020
View reviewed changes
aarlt
aarlt previously approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@aarlt aarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chriseth
Copy link
Contributor

chriseth commented Oct 29, 2020

please squash

@axic
Copy link
Contributor Author

axic commented Oct 29, 2020

please squash

Will do before merging, but any review comments?

@axic
Copy link
Contributor Author

axic commented Oct 29, 2020

@chriseth squashed

@chriseth chriseth merged commit 80071d5 into develop Oct 29, 2020
@chriseth chriseth deleted the ewasm-oob branch October 29, 2020 10:55
@axic axic mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarlt aarlt aarlt left review comments

@cameel cameel Awaiting requested review from cameel

@chriseth chriseth Awaiting requested review from chriseth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@axic @chriseth @aarlt