Remove the usage of boost::noncopyable #11303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this half of the codebase used explicit deleted copy constructors, the others used boost::noncopyable.
cameel
approved these changes
Apr 23, 2021
Contributor
|
My personal take is that if you need to add a comment, it is probably not the best approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7259.
Prior to this half of the codebase used explicit deleted copy constructors, the others used boost::noncopyable. I do not care which approach we take, but would prefer we follow a single one and not a mix as of today.
Disclaimer: I did this a while back, but felt never is a good time submitting more refactorings 😬