Implement London EVMVersion and the BASEFEE opcode #11647

hrkrshnn · 2021-07-12T15:52:05Z

Fixes #11390

Need to fix evmone CI issues.

test/libsolidity/semanticTests/state/block_basefee.sol

axic · 2021-07-12T15:58:48Z

I really fix that just like with Berlin, this shouldn't be a single large PR, but rather:

evmc/evmone
london support + basefee

I would merge 1) now, but would not merge 2) before the hardfork goes live (~3 weeks from now).

hrkrshnn · 2021-07-12T16:01:46Z

@axic I'll split this up, once I can get the CI working.

About the second part, why not add london to evm-version, while keep berlin as the default, and add basefee? We can change the default to london once the hardfork is live.

chriseth · 2021-07-12T16:03:32Z

docs/cheatsheet.rst

  to ``abi.encodeWithSelector(bytes4(keccak256(bytes(signature)), ...)```
 - ``bytes.concat(...) returns (bytes memory)``: :ref:`Concatenates variable number of
  arguments to one byte array<bytes-concat>`
+- ``block.basefee`` (``uint``): current block's basefee


Maybe we should explain basefee (at least mention it) in the documentation and link it here?

axic · 2021-07-12T16:13:06Z

About the second part, why not add london to evm-version, while keep berlin as the default, and add basefee? We can change the default to london once the hardfork is live.

It worked before when we could mark those as "experimental", but you have removed that option 😅

test/EVMHost.cpp

test/evmc/evmc.h

test/EVMHost.cpp

axic · 2021-07-27T16:20:58Z

This looks good to me, though:

Would still wait the extra week until London goes live and only merge this after.
Clean up the commits a tiny bit (e.g. the commit "Updated evmone version to 0.8.0 and evmc version to 9.0.0" has nothing to do with what it says)

chriseth · 2021-07-27T16:57:18Z

test/libyul/objectCompiler/dataoffset_data.yul

 // data_acaf3289d7b601cbd114fb36c4d29c85bbfd5e133f14cb355c3fd8d99367964f 48656c6c6f2c20576f726c6421
 // Bytecode: 6006600055fe48656c6c6f2c20576f726c6421
-// Opcodes: PUSH1 0x6 PUSH1 0x0 SSTORE INVALID 0x48 PUSH6 0x6C6C6F2C2057 PUSH16 0x726C6421000000000000000000000000
+// Opcodes: PUSH1 0x6 PUSH1 0x0 SSTORE INVALID BASEFEE PUSH6 0x6C6C6F2C2057 PUSH16 0x726C6421000000000000000000000000


chriseth · 2021-07-27T16:57:41Z

Why wait? As long as we do not change the default evm version it should be fine.

axic · 2021-07-27T16:59:44Z

Why wait? As long as we do not change the default evm version it should be fine.

Because if the fork falls through there's just extra stuff to be removed. It is really one week away so makes little difference in terms of "stalled PRs" waiting that out :)

leonardoalt

Minor comment, looks good

leonardoalt · 2021-08-09T08:56:14Z

Changelog.md

 * Commandline Interface: option ``--pretty-json`` works also with ``--standard--json``.
 * SMTChecker: Unproved targets are hidden by default, and the SMTChecker only states how many unproved targets there are. They can be listed using the command line option ``--model-checker-show-unproved`` or the JSON option ``settings.modelChecker.showUnproved``.
 * SMTChecker: new setting to enable/disable encoding of division and modulo with slack variables. The command line option is ``--model-checker-div-mod-slacks`` and the JSON option is ``settings.modelChecker.divModWithSlacks``.
+ * Type System: Introduced global ``block.basefee`` for retrieving the base fee of the current block.


Maybe also add the added Yul function?

Added this below.

Isn't this a language feature instead of a compiler feature? Both of them?

Also added basefee to Yul grammar.

Also set the value of `block_base_fee` for testing to 7 wei.

chriseth · 2021-08-09T14:19:14Z

docs/cheatsheet.rst

  to ``abi.encodeWithSelector(bytes4(keccak256(bytes(signature)), ...)```
 - ``bytes.concat(...) returns (bytes memory)``: :ref:`Concatenates variable number of
  arguments to one byte array<bytes-concat>`
+- ``block.basefee`` (``uint``): current block's base fee (EIP-3198 and EIP-1559)


link to the EIP?

Added links and fixed the changelog.

chriseth · 2021-08-10T14:36:27Z

Changelog.md

 ### 0.8.7 (unreleased)

 Language Features:
+ * Type System: Introduced global ``block.basefee`` for retrieving the base fee of the current block.


Suggested change

* Type System: Introduced global ``block.basefee`` for retrieving the base fee of the current block.

* Introduced global ``block.basefee`` for retrieving the base fee of the current block.

(also the code generator is affected)

Fixed this.

chriseth · 2021-08-10T14:37:38Z

liblangutil/EVMVersion.h

 	bool hasSelfBalance() const { return *this >= istanbul(); }
+	bool hasBaseFee() const { return *this >= london(); }

 	bool hasOpcode(evmasm::Instruction _opcode) const;


Needs change

It's done in 0c8b612

Or second commit in #11763

axic · 2021-08-10T22:00:55Z

docs/yul.rst

-| chainid()               |     | I | ID of the executing chain (EIP 1344)                            |
+| chainid()               |     | I | ID of the executing chain (EIP-1344)                            |
+-------------------------+-----+---+-----------------------------------------------------------------+
+| basefee()               |     | L | current block's base fee (EIP-3198 and EIP-1559)                |


The doc on the top also explains what these letters stand for, L is missing.

Thanks. Fixed.

ekpyron

Any reason for not merging #11763 into this first :-)? Strictly speaking, that'd make more sense. Not that it matters too much, if we merge all of them anyways, though.

Anyways, looks fine despite minor comments.

Changelog.md

test/libsolidity/syntaxTests/types/magic_block_basefee_error.sol

hrkrshnn commented Jul 12, 2021

View reviewed changes

test/libsolidity/semanticTests/state/block_basefee.sol Outdated Show resolved Hide resolved

hrkrshnn force-pushed the basefee branch from 5bdb1c4 to 4a23e6c Compare July 12, 2021 15:57

chriseth requested a review from axic July 12, 2021 16:02

chriseth reviewed Jul 12, 2021

View reviewed changes

hrkrshnn force-pushed the basefee branch 2 times, most recently from cc4041d to 2457f10 Compare July 12, 2021 17:16

axic reviewed Jul 13, 2021

View reviewed changes

test/EVMHost.cpp Outdated Show resolved Hide resolved

axic reviewed Jul 13, 2021

View reviewed changes

test/evmc/evmc.h Show resolved Hide resolved

hrkrshnn force-pushed the basefee branch from 2457f10 to 211fb37 Compare July 27, 2021 12:49

hrkrshnn changed the base branch from develop to evmone-upgrade July 27, 2021 12:49

hrkrshnn force-pushed the evmone-upgrade branch from 6caada7 to fe9178e Compare July 27, 2021 12:54

hrkrshnn force-pushed the basefee branch from 211fb37 to a8d628e Compare July 27, 2021 13:01

hrkrshnn force-pushed the evmone-upgrade branch from fe9178e to 1b56fde Compare July 27, 2021 13:23

Base automatically changed from evmone-upgrade to develop July 27, 2021 14:34

hrkrshnn force-pushed the basefee branch from a8d628e to 4902c0c Compare July 27, 2021 15:10

hrkrshnn changed the base branch from develop to update-evmone-part2 July 27, 2021 15:10

Base automatically changed from update-evmone-part2 to develop July 27, 2021 16:18

axic reviewed Jul 27, 2021

View reviewed changes

test/EVMHost.cpp Show resolved Hide resolved

chriseth reviewed Jul 27, 2021

View reviewed changes

argotorg deleted a comment from github-actions bot Jul 27, 2021

hrkrshnn requested a review from axic August 9, 2021 07:58

This was referenced Aug 9, 2021

Set default EVM version to London. #11760

Merged

Updated changes in refunds: EIP-3529 #11761

Merged

leonardoalt reviewed Aug 9, 2021

View reviewed changes

hrkrshnn force-pushed the basefee branch from 116fd60 to 7f741e0 Compare August 9, 2021 09:03

leonardoalt previously approved these changes Aug 9, 2021

View reviewed changes

hrkrshnn added 4 commits August 9, 2021 16:18

Added the instruction basefee.

d92b211

Implemented block.basefee in Solidilty and basefee() in Yul.

95091f6

Also added basefee to Yul grammar.

Added the basefee instruction in YulInterpreter

543ccf5

Added EVMVersion london.

af1dabb

Also set the value of `block_base_fee` for testing to 7 wei.

hrkrshnn dismissed leonardoalt’s stale review via 0f76ffa August 9, 2021 14:18

hrkrshnn force-pushed the basefee branch from 7f741e0 to 0f76ffa Compare August 9, 2021 14:18

chriseth reviewed Aug 9, 2021

View reviewed changes

hrkrshnn force-pushed the basefee branch from 0f76ffa to 3ce5c99 Compare August 9, 2021 14:33

chriseth reviewed Aug 10, 2021

View reviewed changes

hrkrshnn force-pushed the basefee branch from 3ce5c99 to faa3d23 Compare August 10, 2021 14:42

axic reviewed Aug 10, 2021

View reviewed changes

Docs for block.basefee and basefee() in Yul.

cb9b52c

hrkrshnn force-pushed the basefee branch from faa3d23 to 8165348 Compare August 11, 2021 07:27

ekpyron previously approved these changes Aug 11, 2021

View reviewed changes

Changelog.md Outdated Show resolved Hide resolved

test/libsolidity/syntaxTests/types/magic_block_basefee_error.sol Show resolved Hide resolved

hrkrshnn commented Aug 11, 2021

View reviewed changes

test/libsolidity/syntaxTests/types/magic_block_basefee_error.sol Show resolved Hide resolved

Tests and Changelog for basefee.

43605d9

hrkrshnn dismissed ekpyron’s stale review via 43605d9 August 11, 2021 07:51

hrkrshnn force-pushed the basefee branch from 8165348 to 43605d9 Compare August 11, 2021 07:51

ekpyron approved these changes Aug 11, 2021

View reviewed changes

hrkrshnn enabled auto-merge August 11, 2021 07:55

hrkrshnn merged commit 0fc3e2d into develop Aug 11, 2021

hrkrshnn deleted the basefee branch August 11, 2021 08:31

ekpyron mentioned this pull request Dec 20, 2023

Support for BLOBBASEFEE from EIP 7516 #14742

Closed

1 task

	* Type System: Introduced global ``block.basefee`` for retrieving the base fee of the current block.
	* Introduced global ``block.basefee`` for retrieving the base fee of the current block.

Implement London EVMVersion and the BASEFEE opcode #11647

Implement London EVMVersion and the BASEFEE opcode #11647

Uh oh!

Conversation

hrkrshnn commented Jul 12, 2021 • edited by axic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

axic commented Jul 12, 2021

Uh oh!

hrkrshnn commented Jul 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

axic commented Jul 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

axic commented Jul 27, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chriseth commented Jul 27, 2021

Uh oh!

axic commented Jul 27, 2021

Uh oh!

leonardoalt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekpyron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hrkrshnn commented Jul 12, 2021 •

edited by axic

Loading