updated public to external for the functions #11772
Conversation
| function winnerName() external view | ||
| returns (bytes32 winnerName_) | ||
| { | ||
| winnerName_ = proposals[winningProposal()].name; |
There was a problem hiding this comment.
winningProposal is used here. So that has to be made public. Here's the CI check that failed: https://app.circleci.com/pipelines/github/ethereum/solidity/17880/workflows/1a6d2776-037e-462b-a52c-a88feed5f637/jobs/799349
Could you please fix it in this PR / branch itself? We have a section on workflow for pull requests that may be relevant here: https://docs.soliditylang.org/en/v0.8.6/contributing.html?highlight=evmone#workflow-for-pull-requests
There was a problem hiding this comment.
Ok i will use the same PR request to make new changes
There was a problem hiding this comment.
Thanks. You can ping me by using "re request" review button next to the Reviewers list.
There was a problem hiding this comment.
Could you also update other files from docs/examples/*.rst?
There was a problem hiding this comment.
Of course i will update the others as well
|
Generally looks good. I'll take another look after the rest of the examples are changed. It would be nice to squash the commits into a single one before we can merge it. But I can also do it at the end, if you aren't familiar with this. |
|
Please make sure that the explanation before and after the code is still OK with the code. |
|
Will squash the commits now. |
changed public to external for the functions
hrkrshnn
force-pushed
the
v-sreekesh-external-fix-voting
branch
from
e99aaf7 to
9b9e52e
Compare
|
@v-sreekesh Thanks for the PR! The CI seems to be broken now. Will merge once it gets fixed. |
|
It's only the windows build that is failing. Will force-merge this. |
3 participants
changed public to external for the functions
Closes #11768