Some more base fees. #11785
Merged
Some more base fees. #11785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not important for the release. |
|
Tests need update |
chriseth
force-pushed
the
someMoreBaseFees
branch
from
4303c99 to
58394f1
Compare
|
I'll fix the tests |
leonardoalt
force-pushed
the
someMoreBaseFees
branch
2 times, most recently
from
740b9ef to
389b969
Compare
leonardoalt
force-pushed
the
someMoreBaseFees
branch
from
389b969 to
c87c0f0
Compare
leonardoalt
approved these changes
Aug 12, 2021
|
@leonardoalt can you explain why there are so many test updates needed in tests that do not even use |
leonardoalt
reviewed
Aug 12, 2021
| (declare-fun |state_0| () |state_type|) | ||
| (declare-datatypes ((|bytes_tuple| 0)) (((|bytes_tuple| (|bytes_tuple_accessor_array| (Array Int Int)) (|bytes_tuple_accessor_length| Int))))) | ||
| (declare-datatypes ((|tx_type| 0)) (((|tx_type| (|block.chainid| Int) (|block.coinbase| Int) (|block.difficulty| Int) (|block.gaslimit| Int) (|block.number| Int) (|block.timestamp| Int) (|blockhash| (Array Int Int)) (|msg.data| |bytes_tuple|) (|msg.sender| Int) (|msg.sig| Int) (|msg.value| Int) (|tx.gasprice| Int) (|tx.origin| Int))))) | ||
| (declare-datatypes ((|tx_type| 0)) (((|tx_type| (|block.basefee| Int) (|block.chainid| Int) (|block.coinbase| Int) (|block.difficulty| Int) (|block.gaslimit| Int) (|block.number| Int) (|block.timestamp| Int) (|blockhash| (Array Int Int)) (|msg.data| |bytes_tuple|) (|msg.sender| Int) (|msg.sig| Int) (|msg.value| Int) (|tx.gasprice| Int) (|tx.origin| Int))))) |
There was a problem hiding this comment.
you added basefee as a transaction variable in the SMT encoding, this effectively changes every single SMT query. When the query changes syntactically, 1) the result proved/unproved might change 2) the counterexamples might change
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.