[SMTChecker] Fix false positive on external calls from constructors #11795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
force-pushed
the
smt_fix_ext_constructor
branch
2 times, most recently
from
b081fbe to
54e7b82
Compare
leonardoalt
commented
Aug 12, 2021
| function s(uint _x) public { x = _x; } | ||
| constructor(D d) { | ||
| uint a = d.ext(this); | ||
| assert(x == 0); // should hold because there's no reentrancy from the constructor |
There was a problem hiding this comment.
Before this PR this used to fail
ekpyron
previously approved these changes
Aug 12, 2021
| for (auto var: function->returnParameters()) | ||
| m_context.variable(*var)->increaseIndex(); | ||
|
|
||
| if (!m_currentFunction || m_currentFunction->isConstructor()) |
There was a problem hiding this comment.
!m_currentFunction is stuff like state variable initialization and thereby always constructor context I guess?
There was a problem hiding this comment.
If !m_currentFunction here, it means there was a state variable init that made an external call
leonardoalt
force-pushed
the
smt_fix_ext_constructor
branch
from
54e7b82 to
6ee60aa
Compare
|
@ekpyron can you reapprove? had to fix test expectations that I forgot |
ekpyron
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't add the nondeterministic interface constraint for external calls from constructors since they can't re-enter anyway.