-
Notifications
You must be signed in to change notification settings - Fork 6.3k
More strongly recommend to use the latest version #12093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hrkrshnn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is fine by me. I will wait to see what others in the team think about making the recommendation stronger.
docs/index.rst
Outdated
| version of Solidity. This is because breaking changes as well as | ||
| new features and bug fixes are introduced regularly. We currently use | ||
| a 0.x version number `to indicate this fast pace of change <https://semver.org/#spec-item-4>`_. | ||
| When deploying contracts, you should only use the latest released version of Solidity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this reads (and has read before) a bit weird - maybe we should instead emphasize that you should use the latest version because only it is guaranteed to gets security fixes (sometimes we also fix older versions)?
|
My goal here is to make this language as strong as the Solidity team will allow. My preference is:
|
|
Totally fine, @fulldecent - my comment was mainly about restructuring the paragraph so that it is clearer why we only recommend the latest version. |
cameel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the wording is ok now and the text does reflect our general policy.
|
@fulldecent Can you squash your commits and rebase on the latest |
The publish Solidity security policy should be helpful to people when deciding which version of Solidity to use. So a reference is added.