Remove CircleCI+Homebrew workarounds #12151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
reviewed
Oct 18, 2021
docs/yul.rst
Outdated
| Identifiers can be arbitrary but when the compiler produces Yul code from Solidity sources, | ||
| it uses a library name qualified with the name of the source unit that defines that library. | ||
| To link the code with a particular library address, the same identifier must be provided to the | ||
| ``--libraries`` option on the command line. |
Collaborator
Author
There was a problem hiding this comment.
Oh, looks like I started the PR on top of #12144 rather than develop. Fixed.
cameel
force-pushed
the
remove-homebrew-workarounds
branch
from
099769c to
70d78a0
Compare
leonardoalt
approved these changes
Oct 18, 2021
Contributor
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response from CircleCI regarding the workarounds we had to do in #12106/#12131 made me realize that maybe we can just remove the
brew updatethat causes this problem in the first place. We added it in #11267 because of the breakage caused by Boost binaries moving away from bintray - a newer version of Homebrew was needed to resolve it. Looks like CircleCI updated Homebrew in their images sobrew updateis no longer needed.