Labels in issue templates #12412
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,17 @@ | ||
| --- | ||
| name: Documentation Issue | ||
| about: Solidity documentation. | ||
| labels: ["documentation :book:"] | ||
| --- | ||
|
|
||
| ## Page | ||
|
|
||
| <!--Please link directly to the page which you think has a problem.--> | ||
|
|
||
| ## Abstract | ||
|
|
||
| <!--Please describe in detail what is wrong.--> | ||
|
|
||
| ## Pull request | ||
|
|
||
| <!--Please link to your pull request which resolves this issue.--> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,37 @@ | ||
| --- | ||
| name: Feature Request | ||
| about: Solidity language or infrastructure feature requests. | ||
| labels: ["feature"] | ||
| --- | ||
|
|
||
| <!--## Prerequisites | ||
|
|
||
| - First, many thanks for taking part in the community. We really appreciate that. | ||
| - We realize there is a lot of data requested here. We ask only that you do your best to provide as much information as possible so we can better help you. | ||
| - Support questions are better asked in one of the following locations: | ||
| - [Solidity chat](https://gitter.im/ethereum/solidity) | ||
| - [Stack Overflow](https://ethereum.stackexchange.com/) | ||
| - Ensure the issue isn't already reported (check `feature` and `language design` labels). | ||
|
|
||
| *Delete the above section and the instructions in the sections below before submitting* | ||
| --> | ||
|
|
||
| ## Abstract | ||
|
|
||
| <!--Please describe by example what problem you see in the current Solidity language and reason about it.--> | ||
|
|
||
| ## Motivation | ||
|
|
||
| <!--In this section you describe how you propose to address the problem you described earlier, including by giving one or more exemplary source code snippets for demonstration.--> | ||
|
|
||
| ## Specification | ||
|
|
||
| <!--The technical specification should describe the syntax and semantics of any new feature. The specification should be detailed enough to allow any developer to implement the functionality.--> | ||
|
|
||
| ## Backwards Compatibility | ||
|
|
||
| <!-- | ||
| All language changes that introduce backwards incompatibilities must include a section describing these incompatibilities and their severity. | ||
|
|
||
| Please describe how you propose to deal with these incompatibilities. | ||
| --> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently (at least that's how I have handled it), the label served the purpose of "confirmed bug". What do we want to do about that? Just keep the label and use the project columns to track confirmed / not confirmed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had doubts about this myself because of that system. Maybe we should actually change it? I think it would be useful to have this stuff immediately categorized and a
confirmedlabel would have more obvious meaning - the current system is a bit too implicit.But I can remove it from the template if you prefer to stay with the current system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the columns in the project to mark it as confirmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so not in
New issuesmeans that it's confirmed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes