Skip to content

Conversation

@ekpyron
Copy link
Collaborator

@ekpyron ekpyron commented Jul 15, 2024

Fixes #15134

If someone is up for trying to craft a minimal test case for this, feel free to go ahead!

@ekpyron ekpyron marked this pull request as ready for review July 15, 2024 15:25
@ekpyron ekpyron force-pushed the subObjectNonDeterminism branch from b99da11 to d6d51f6 Compare July 15, 2024 15:37
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks fine but I think we should cover it with at least a simple regression test before we merge.

ekpyron and others added 3 commits July 16, 2024 17:55
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
@ekpyron ekpyron force-pushed the subObjectNonDeterminism branch from f37463e to c78b7e2 Compare July 16, 2024 15:59
@ekpyron ekpyron requested a review from clonker July 16, 2024 16:06
@ekpyron ekpyron enabled auto-merge July 16, 2024 16:13
@ekpyron ekpyron merged commit 9d90b39 into develop Jul 16, 2024
@ekpyron ekpyron deleted the subObjectNonDeterminism branch July 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different bytecode produced via IR for some of OpenZeppelin's contracts when extra contracts are included in the input

4 participants