Fix isoltest crash when formatting call arguments in a contract whose ABI includes unnamed functions #15269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
fix-isoltest-crash-on-arg-formatting-when-abi-has-unnamed-functions
branch
from
772e476 to
eb713c8
Compare
Collaborator
Author
|
The buggy logic is used only for formatting expectations when a test fails in interactive mode so it went undiscovered until now. It's not even possible to cover it with a test. It can be easily reproduced, but we would not add such a test since the expectations do not match: contract C {
constructor() {}
function f() external pure returns (bytes32) {}
}
// ----
// constructor()
// f() -> 42 |
r0qs
approved these changes
Jul 18, 2024
cameel
force-pushed
the
fix-isoltest-crash-on-arg-formatting-when-abi-has-unnamed-functions
branch
from
eb713c8 to
23ca369
Compare
nikola-matic
approved these changes
Jul 19, 2024
… ABI includes entries without names - functionSignatureFromABI() would attempt to calculate signature for a function even if it had no name (i.e. was a constructor, fallback or receive). This would lead to a crash. - The buggy logic is used only for formatting expectations when an test fails in interactive mode.
cameel
force-pushed
the
fix-isoltest-crash-on-arg-formatting-when-abi-has-unnamed-functions
branch
from
23ca369 to
1a5335a
Compare
cameel
deleted the
fix-isoltest-crash-on-arg-formatting-when-abi-has-unnamed-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in isoltest discovered by @rodiazet.
functionSignatureFromABI()would attempt to calculate signature for a function even if it had no name in the ABI (which is the case for constructors, fallback and receive). This would lead to a crash.