Skip to content

eof: Update yulSyntaxTests tests for EOF #15660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

eof: Update yulSyntaxTests tests for EOF #15660

merged 1 commit into from
Jan 28, 2025

Conversation

@rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Dec 19, 2024

  • Disable test which don't make sense for EOF bytecode format.
  • Create EOF yul syntax tests counterparts.

@github-actions
Copy link

github-actions bot commented Dec 19, 2024

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@rodiazet rodiazet force-pushed the eof-update-yul-syntax-tests branch from 914dbb9 to 2ca82d3 Compare December 19, 2024 15:24
@rodiazet rodiazet mentioned this pull request Dec 19, 2024
Merged
cameel
cameel requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like in #15661, there are better ways to resolve some of these than just disabling them on EOF.

@rodiazet rodiazet force-pushed the eof-update-yul-syntax-tests branch 4 times, most recently from 28fbc70 to 47f2dce Compare January 9, 2025 11:41
cameel
cameel reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things I pointed out are now fixed but there's one more test needs to be adjusted (it was it either added after my last review or I missed it somehow).

@rodiazet
Copy link
Contributor Author

rodiazet commented Jan 22, 2025 •
edited
Loading

I haven't added anything since your last review I think. Which tests do you have in mind?

@rodiazet rodiazet force-pushed the eof-update-yul-syntax-tests branch 3 times, most recently from ae17ec3 to 9b7653f Compare January 22, 2025 15:15
cameel
cameel approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Please squash the fixes and we can merge.

@rodiazet rodiazet force-pushed the eof-update-yul-syntax-tests branch 3 times, most recently from fda1003 to 12067ee Compare January 28, 2025 10:16
@rodiazet
Copy link
Contributor Author

rodiazet commented Jan 28, 2025

Squashed and rebased. We can merge now.

@rodiazet rodiazet force-pushed the eof-update-yul-syntax-tests branch from 12067ee to bc0b9c1 Compare January 28, 2025 20:09
@cameel cameel merged commit 8c54f4d into argotorg:develop Jan 28, 2025
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameel cameel cameel approved these changes

Assignees

No one assigned

Labels

EOF external contribution ⭐ testing 🔨

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rodiazet @cameel