Skip to content

Fixed internal error related to ecrecover and ABIEncoderV2. #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

Fixed internal error related to ecrecover and ABIEncoderV2. #6000

merged 1 commit into from
Feb 19, 2019

Conversation

@chriseth
Copy link
Contributor

@chriseth chriseth commented Feb 13, 2019

Fixes #5997

leonardoalt
leonardoalt reviewed Feb 13, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #6000 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6000      +/-   ##
===========================================
+ Coverage    88.32%   88.33%   +<.01%     
===========================================
  Files          361      361              
  Lines        34793    34804      +11     
  Branches      4123     4124       +1     
===========================================
+ Hits         30732    30743      +11     
  Misses        2684     2684              
  Partials      1377     1377
Flag Coverage Δ
#all 88.33% <100%> (ø) ⬆️
#syntax 27.82% <8.33%> (-0.01%) ⬇️

leonardoalt
leonardoalt previously approved these changes Feb 13, 2019
View reviewed changes
Copy link

@leonardoalt leonardoalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tests work

chriseth
chriseth commented Feb 13, 2019
View reviewed changes
Copy link
Contributor Author

@chriseth chriseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs more fixes, at least #5102 has some failures that look similar.

@chriseth
Copy link
Contributor Author

chriseth commented Feb 18, 2019

It turns out there was only a single other problem and it is a little bit different. Will create a new PR for it.

@chriseth chriseth mentioned this pull request Feb 18, 2019
Merged
leonardoalt
leonardoalt previously approved these changes Feb 18, 2019
View reviewed changes
@chriseth chriseth merged commit d9e4a10 into develop Feb 19, 2019
@axic axic deleted the fixECRecoverABIV2 branch February 19, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leonardoalt leonardoalt leonardoalt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriseth @leonardoalt