Fix combination of delegatecall and ABIEncoderV2. #6029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6029 +/- ##
==========================================
Coverage ? 88.63%
==========================================
Files ? 359
Lines ? 34609
Branches ? 4091
==========================================
Hits ? 30675
Misses ? 2574
Partials ? 1360
|
leonardoalt
previously approved these changes
Feb 18, 2019
We can set the flag to false for bare delegatecall, because we always send a memory string and never a storage reference.
chriseth
force-pushed
the
fixDelegatecallV2
branch
from
fbcb697 to
d5791fe
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set the flag to false for bare delegatecall, because we always
send a memory string and never a storage reference.