Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the directory problem when loading the map #113

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

engyasin
Copy link
Contributor

@engyasin engyasin commented Feb 19, 2023

PR Summary

The 'WindowPath' object of the map .json file , would load the whole directory once again when loading the map, which render the directory wrong., like issue #102
Instead only the file name should be taken, with .name simply

Testing

The change is minimal. The tutorial notebook works now.

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

@benjaminrwilson benjaminrwilson merged commit b260482 into argoverse:main Mar 22, 2023
@benjaminrwilson
Copy link
Collaborator

Thanks, @engyasin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants