Feature/sf #124

nchodosh · 2023-03-20T04:10:10Z

PR Summary

Added an extension to the API to compute scene-flow pseudo labels and added utilities for submitting to the CVPR challenge.

Testing

Everything that is factored into methods has unit test coverage. That leaves out some argument parsing code in scripts.

In order to ensure this PR works as intended, it is:

unit tested.
other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
A well-written summary explains what was done and why it was done.
The PR is adequately tested and the testing details and links to external results are included.

Remove cast.

…nto feature/rust

…ture/sf

src/av2/evaluation/scene_flow/eval.py

src/av2/evaluation/scene_flow/example_submission.py

src/av2/evaluation/scene_flow/make_annotation_files.py

src/av2/evaluation/scene_flow/make_submission_archive.py

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

src/av2/evaluation/scene_flow/eval.py

src/av2/torch/structures/flow.py

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

src/av2/evaluation/scene_flow/utils.py

src/av2/torch/structures/flow.py

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

src/av2/torch/structures/flow.py

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

…into feature/sf

benjaminrwilson and others added 30 commits March 13, 2023 18:57

Remove test data.

3be0f60

Remove pandas stubs.

0be4d6d

Add docstrings.

fcbd2f1

Add docstrings.

07140a0

Reorganize files.

de6ba7a

Cleanup dataloader get method.

8e50166

Minor fixes on docstrings.

9e30925

Fix args ordering.

9df40e0

Add additional comments.

688c4b1

Update docstring.

3f6848c

Add image deps.

02d6804

Update arg.

e2848c3

Update readmes.

1e02e33

Add additional readme + remove unused code.

c6146d1

Fix lint.

a51e369

Add option type for annotations.

e6d1a97

Remove hard-coded mmap.

afe0cf7

Update readmes.

19384c9

Update torch init.

5c560bd

Fix utils shapes.

07b7eff

Update typing.

e5fea8a

Modify docstring.

2309934

Update utils.py

9baffc6

Remove cast.

added scene flow extension to the API

22cd423

Add maximize build space.

c618359

Merge branch 'feature/rust' of https://github.com/argoverse/av2-api i…

fdf6ae0

…nto feature/rust

fix type and linter errors

60333d1

black and isort

f7dbea8

Comment out torch temporarily.

027b21a

added docstring

242c6aa

nchodosh added 3 commits March 21, 2023 16:12

refactor compute_metrics

2c03b4a

Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…

8e0530e

…ture/sf

Merge branch 'feature/sf' into auto-sf-labels

678eb8b

benjaminrwilson requested changes Mar 21, 2023

View reviewed changes

nchodosh and others added 4 commits March 21, 2023 16:26

Apply suggestions from code review

f0376aa

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

working

bcc8463

Apply PR suggestions

2a9143e

Merge branch 'feature/sf' into auto-sf-labels

1c25325

benjaminrwilson requested changes Mar 21, 2023

View reviewed changes

src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved

src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved

src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved

src/av2/torch/structures/flow.py Outdated Show resolved Hide resolved

nchodosh and others added 4 commits March 21, 2023 16:52

Apply suggestions from code review

6f43d54

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

closer

bcc520a

more refactoring

0f3a680

Merge branch 'feature/sf' into auto-sf-labels

74e5bdf

benjaminrwilson requested changes Mar 21, 2023

View reviewed changes

nchodosh and others added 7 commits March 21, 2023 17:18

Apply suggestions from code review

00fa21c

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

making tests

91c256a

PR suggestions

7f52be1

finished

4a1d6b6

Merge branch 'auto-sf-labels' into feature/sf

da979ec

deleted unused format files

dc014a4

Fix circular import.

6a4e8d8

benjaminrwilson reviewed Mar 21, 2023

View reviewed changes

src/av2/torch/structures/flow.py Outdated Show resolved Hide resolved

benjaminrwilson reviewed Mar 21, 2023

View reviewed changes

src/av2/torch/structures/flow.py Outdated Show resolved Hide resolved

benjaminrwilson and others added 6 commits March 21, 2023 16:38

Update src/av2/torch/structures/flow.py

1c0db1a

Update src/av2/torch/structures/flow.py

fd12cd3

Co-authored-by: Benjamin Wilson <benjaminrwilson@users.noreply.github.com>

Fix circular import.

b9d50be

Merge branch 'feature/sf' of https://github.com/argoverse/av2-api-sf …

cc02801

…into feature/sf

Fix line length.

d075f35

formatting

fddfa63

benjaminrwilson merged commit 27d3b40 into argoverse:main Mar 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/sf #124

Feature/sf #124

nchodosh commented Mar 20, 2023 •

edited

Loading

Feature/sf #124

Feature/sf #124

Conversation

nchodosh commented Mar 20, 2023 • edited Loading

PR Summary

Testing

Compliance with Standards

nchodosh commented Mar 20, 2023 •

edited

Loading