[IV-21-22] Objetivo 3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to review 👀 @JJ |
JJ
suggested changes
Nov 22, 2021
docs/dev_tools.md
Outdated
|
|
||
| ### Invoke | ||
|
|
||
| [Invoke](https://www.pyinvoke.org/) is our task runner of choice. |
There was a problem hiding this comment.
You have to show what are the requirements for these, which other alternatives you have considered, and why this was the one you chose.
|
Also, submit the PR. |
|
Added alternatives in Ready to review @JJ |
JJ
approved these changes
Nov 28, 2021
| was being more used to Python and finding easier to work with | ||
| Invoke's approach. | ||
|
|
||
| - [doit](https://pydoit.org/contents.html#) |
There was a problem hiding this comment.
You can't list stuff and a posteriori reasons to not choose them; all requirements need to be laid out in advance, as I commented in class. Please bear this in mind, because it will become increasingly important in the rest of the objectives.
There was a problem hiding this comment.
ok, I'll keep it in mind for the next ones, thanks! 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Poetry for dependency management and Invoke as a task runner tool. The documentation,
iv.yamlfile andREADME.mdof the project were modified accordingly to incorporate these changes.