ci: Use configurable !benchmark PR comment
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Feb 17, 2024
…uter#308) * move KZG engine to provider module; update paths everywhere * add a sparse matrix entry only if the coefficient is non-zero; update digests * move test code to place where it is used * move asm to default and add a note * update constants * update link * simplify test_pp_digest
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Feb 17, 2024
…uter#308) * move KZG engine to provider module; update paths everywhere * add a sparse matrix entry only if the coefficient is non-zero; update digests * move test code to place where it is used * move asm to default and add a note * update constants * update link * simplify test_pp_digest
huitseeker
pushed a commit
that referenced
this pull request
Feb 17, 2024
* move KZG engine to provider module; update paths everywhere * add a sparse matrix entry only if the coefficient is non-zero; update digests * move test code to place where it is used * move asm to default and add a note * update constants * update link * simplify test_pp_digest
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Feb 19, 2024
…uter#308) * move KZG engine to provider module; update paths everywhere * add a sparse matrix entry only if the coefficient is non-zero; update digests * move test code to place where it is used * move asm to default and add a note * update constants * update link * simplify test_pp_digest
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
* update README; update version (#303) * Miscellaneous improvements (details in commit messages) (#308) * move KZG engine to provider module; update paths everywhere * add a sparse matrix entry only if the coefficient is non-zero; update digests * move test code to place where it is used * move asm to default and add a note * update constants * update link * simplify test_pp_digest * chore: update expect tests * Improvements to error handling and naming (#309) * rename and introduce checks about length * introduce a test about public IO * chore: remove needless annotation --------- Co-authored-by: Srinath Setty <srinath@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable
!benchmarkPR commentUses the reusable workflow from argumentcomputer/ci-workflows#38. This replaces the existing
!gpu-benchmarkcommand with!benchmark, as shown in the following examples:This will run the default benchmark settings, specified in the workflow file of this PR.
Alternatively:
This will run with each of the input benchmarks, features, and env vars.
Important
--features cudain the comment body (see above example). Otherwise, the benchmarks will still run on the same GPU-equipped benchmark machine, but will run using the CPU only.Details
!gpu-benchmarksyntax will no longer work. The command must start with!benchmark.--benchwill spawn a new CI job, which means they will each output a separate comment.The default env vars specified in this PR are
If identically named env vars are specified in the
!benchmarkcomment, they will overwrite the above defaults.See also argumentcomputer/lurk-beta#1114