Fold the non_hiding_kzg module in relevant files #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gumentcomputer#269)" This reverts commit db4375f.
huitseeker
force-pushed
the
remove_batch
branch
from
a11c34c
to
32e2be3
Compare
huitseeker
changed the title
huitseeker
changed the title
huitseeker
force-pushed
the
remove_batch
branch
from
c6fe980
to
6a888a8
Compare
huitseeker
force-pushed
the
remove_batch
branch
from
6a888a8
to
9c8d440
Compare
…eed it - Moved `UniversalParams` and several dependent structures for the KZG10 scheme in the `kzg_commitment.rs` file. - Deleted the `non_hiding_kzg.rs` file, - Consolidated KZG related structs under the `kzg_commitment` module, - Updated `mod.rs` to reflect the removal of the `non_hiding_kzg` module.
huitseeker
force-pushed
the
remove_batch
branch
from
9c8d440
to
94ba466
Compare
storojs72
approved these changes
Feb 19, 2024
|
LGTM, Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* optimize computation of cross-term * clippy fixes * cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the contents of Univariate KZG in two locations:
kzg_commitments, for those types needed there (essentially setting up the public parameters),non_hiding_zeromorph, for the parts specifically used by ZM (and not yet by HyperKZG/Shplonk)