Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dependency updates, incl. elsa #888

Merged
merged 2 commits into from
Nov 15, 2023
Merged

chore: dependency updates, incl. elsa #888

merged 2 commits into from
Nov 15, 2023

Conversation

huitseeker
Copy link
Contributor

Updates to match Manishearth/elsa#67

@huitseeker huitseeker requested review from a team as code owners November 14, 2023 20:44
@huitseeker
chore: Update Elsa dependency and correct import paths
930bf76 
- Updated Elsa dependency branch from `sync_index_map` to `sync_frozen`.
- the elsa import now matches Manishearth/elsa#67 and thus a more recent version of elsa.

- Corrected the  import statement in `hash.rs`.
- Modified import paths for `FrozenIndexSet` in the `store.rs` and `lem/store.rs` files.
@huitseeker
chore: update criterion dependency
806ddf2
@arthurpaulino
Copy link
Member

This needs a
!gpu-benchmark

@github-actions GitHub Actions
Copy link
Contributor

Benchmark for b65ded0

Click to view benchmark
Test Base PR %
LEM Fibonacci Prove - rc = 100/fib/num-100 7.7±0.03s 7.7±0.04s 0.00%
LEM Fibonacci Prove - rc = 100/fib/num-200 15.6±0.06s 15.6±0.08s 0.00%

@arthurpaulino
Copy link
Member

arthurpaulino commented Nov 14, 2023 •
edited
Loading

Wait, did it benchmark the wrong commitment? I would expect it to benchmark 806ddf2
@samuelburnham

@samuelburnham
Copy link
Member

samuelburnham commented Nov 14, 2023 •
edited
Loading

I would expect it to benchmark 806ddf2

It appears to be working correctly, as the criterion-compare-action uses the base branch in the comment heading. A 0.0% change is always a bit suspicious given the usual presence of noise, but e.g. #889 (comment) shows minor variance as we would expect.

arthurpaulino
arthurpaulino approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@arthurpaulino arthurpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huitseeker huitseeker added this pull request to the merge queue Nov 15, 2023
Merged via the queue into argumentcomputer:main with commit 4543009 Nov 15, 2023
12 checks passed
@huitseeker huitseeker deleted the dep_updates branch November 15, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurpaulino arthurpaulino arthurpaulino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huitseeker @arthurpaulino @samuelburnham