Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lib out of example #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

johnchandlerburnham
Copy link
Member

I think we can move things to the top level.

@arthurpaulino does this require some plumbing on the lurk-rs side? If so I think we can merge here and then PR there with that work + updating the git submodule

@arthurpaulino
Copy link
Member

Yeah, it will require some changes.

I can already see that some files listed in test_lurk_lib wouldn't be found after this change.

Also, did you check if all the load meta commands on those files will still work? Because that would be a self-contained breakage in the lib itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants