-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extras buttons.min.css
#154
Conversation
Visit the preview URL for this PR (updated for commit 65fc673): https://open-props--pr154-buttons-x5db5f1l.web.app (expires Thu, 03 Feb 2022 03:13:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
add |
move normalize.css button styles into this file |
gonna need docs or some docs built into a demo codepen, so stuff like below doesnt need discovered. filled indigo customized OP button: .btn-solid {
--_bg: var(--indigo-6);
--_border: var(--indigo-5);
--_text: var(--indigo-0);
--_ink-shadow: 0 1px 0 var(--indigo-8);
} |
2 small firefox issues:
|
Amazing. I think the key thing here will be explaining that:
I started a really simple docs example to showcase some of these thoughts. |
seein that def gets me pumped! i bet we could easily build a little experience too that changes the accent color, size and text colors. spit out the tiny bits of mod props needed, they can copy and paste them in their css for some branded looks 🙂 i think we need an Extra section in the bottom nav instead of Buttons tho:In extra we can document normalize props and the buttons. v1 def doesnt need to be interactive. my idea up until now was to make a normalize codepen and a buttons codepen, and kinda docublog them there. i really like the idea of an Extras section tho, really going to help clear things up. makes this related to #89 👍🏻 |
docs to come in a separate PR, this is ready for early access |
* v0.4 ported * fixes multi-line * moves normalize styles * adds size as a single lever to customize * file upload button support * proper cursor for file input * fixes firefox not allowing comments as values breaking the styling system * fixes firefox svg path not colorized * fileinput space matches inline padding * cut release, for eap buttons.min.css
fixes #152
play around with the plain css prototype here