Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ad-hoc test_ssl threaded server with ThreadedTCPServer #3

Open
arhadthedev opened this issue May 7, 2022 · 5 comments
Open

Replace ad-hoc test_ssl threaded server with ThreadedTCPServer #3

arhadthedev opened this issue May 7, 2022 · 5 comments

Comments

@arhadthedev
Copy link
Owner

No description provided.

@arhadthedev
Copy link
Owner Author

arhadthedev commented May 7, 2022 •
edited
Loading

@arhadthedev
Copy link
Owner Author

ThreadedTCPServer still requires manual creation of a server thread. Its threaded nature is in creation of a thread for each individual client. So closing.

Repository owner moved this from Todo to Done in PR Drafts May 7, 2022
@arhadthedev
Copy link
Owner Author

The test_ssl actually uses this threaded model. Reopening.

@arhadthedev arhadthedev reopened this May 7, 2022
@arhadthedev arhadthedev changed the title Replace divercity of ad-hoc threaded test servers with ThreadedTCPServer Replace ad-hoc test_ssl threaded server with ThreadedTCPServer May 7, 2022
@arhadthedev
Copy link
Owner Author

The issue is postponed because the changes broke tests, and I couldn't find why yet. The changes live in
https://github.com/python/cpython/compare/3f61db475692511a9676765e6f9f0bb204306e93...arhadthedev:threadedserver?expand=1.

arhadthedev pushed a commit that referenced this issue Jun 8, 2022
@gpshead
pythongh-89455: Fix an uninitialized bool in exception print context. (…
861974b 
…python#91466)

Fix an uninitialized bool in exception print context.
    
`struct exception_print_context.need_close` was uninitialized.
    
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
    
https://oss-fuzz.com/testcase-detail/6217746058182656
    
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
    #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
    #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
    #2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
    #3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
    
Pretty obvious what the ommission was upon code inspection.
@arhadthedev
Copy link
Owner Author

The issue is postponed

Fixed, so CPython PR 92475 is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
PR Drafts
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arhadthedev