Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused deprecated functions #211

Closed
lgeretti opened this issue Sep 22, 2018 · 2 comments
Closed

Remove unused deprecated functions #211

lgeretti opened this issue Sep 22, 2018 · 2 comments
Assignees
Labels
proposal Something new or different that is not strictly an improvement
Milestone

Comments

@lgeretti
Copy link
Member

lgeretti commented Sep 22, 2018

I suggest we get rid of any unused deprecated function for the next 2.0 release. This is usually the appropriate moment to do such a cleanup.

For example several functions in function/scaled_function_patch.tpl.hpp have the ARIADNE_DEPRECATED macro guard in place, but it is not triggered and therefore can be safely removed.

@lgeretti lgeretti added the proposal Something new or different that is not strictly an improvement label Sep 22, 2018
@lgeretti lgeretti added this to the 2.0 official release milestone Sep 22, 2018
@lgeretti lgeretti self-assigned this Sep 22, 2018
@pietercollins
Copy link
Contributor

pietercollins commented Sep 24, 2018 via email

@lgeretti
Copy link
Member Author

Yep, how much as possible. I may do a check by adding the deprecated guard on each and every deprecated function to see if it is actually used. If it is not, I will remove the function. If it is, I will make an issue about it.

@lgeretti lgeretti changed the title Remove unused deprecated functions for the next release Remove unused deprecated functions Apr 2, 2021
@lgeretti lgeretti closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Something new or different that is not strictly an improvement
Development

No branches or pull requests

2 participants