You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest we get rid of any unused deprecated function for the next 2.0 release. This is usually the appropriate moment to do such a cleanup.
For example several functions in function/scaled_function_patch.tpl.hpp have the ARIADNE_DEPRECATED macro guard in place, but it is not triggered and therefore can be safely removed.
The text was updated successfully, but these errors were encountered:
________________________________
From: Luca Geretti <notifications@github.com>
Sent: 22 September 2018 22:04
To: ariadne-cps/development
Cc: Subscribed
Subject: [ariadne-cps/development] Remove unused deprecated functions for the next release (#211)
I suggest we get rid of any deprecated function for the next 2.0 release. This is usually the appropriate moment to do such a cleanup.
For example several functions in function/scaled_function_patch.tpl.hpp have the ARIADNE_DEPRECATED macro guard in place, but it is not triggered and therefore can be safely removed.
-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#211>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARaq6AdL0_RwLlmPde3KdW04k0Q76Cbmks5udpfBgaJpZM4W1a9p>.
Yep, how much as possible. I may do a check by adding the deprecated guard on each and every deprecated function to see if it is actually used. If it is not, I will remove the function. If it is, I will make an issue about it.
I suggest we get rid of any unused deprecated function for the next 2.0 release. This is usually the appropriate moment to do such a cleanup.
For example several functions in
function/scaled_function_patch.tpl.hpp
have the ARIADNE_DEPRECATED macro guard in place, but it is not triggered and therefore can be safely removed.The text was updated successfully, but these errors were encountered: