Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up evolver interface from reach/evolve/reach_evolve methods #552

Closed
lgeretti opened this issue May 2, 2021 · 0 comments
Closed

Clean up evolver interface from reach/evolve/reach_evolve methods #552

lgeretti opened this issue May 2, 2021 · 0 comments
Assignees
@lgeretti
Labels
deficiency Un undesirable feature which is not a bug dynamics Dynamics module hybrid Hybrid module
Milestone
Efficiency and im...

Comments

@lgeretti
Copy link
Member

lgeretti commented May 2, 2021 •
edited
Loading

The evolver interface (and corresponding hybrid) features reach/evolve/reach_evolve that are essentially useless, since the implementation is the same as orbit but it returns a specific set. No tests use those and no Python bindings are written for them. We shall just rely on orbit for simplicity.
@lgeretti lgeretti added dynamics Dynamics module deficiency Un undesirable feature which is not a bug labels May 2, 2021
@lgeretti lgeretti self-assigned this May 2, 2021
@lgeretti lgeretti added the hybrid Hybrid module label May 2, 2021
lgeretti added a commit that referenced this issue May 2, 2021
@lgeretti
Remove evolve/reach/reach_evolve from evolver interface (solves #552)
07ca99e
@lgeretti lgeretti closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgeretti lgeretti

Labels
deficiency Un undesirable feature which is not a bug dynamics Dynamics module hybrid Hybrid module
Milestone
Efficiency and improved internal orga...
Development

No branches or pull requests
1 participant
@lgeretti