Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default to Semantics::UPPER in evolver orbit #556

Closed
lgeretti opened this issue May 2, 2021 · 0 comments
Closed

Remove default to Semantics::UPPER in evolver orbit #556

lgeretti opened this issue May 2, 2021 · 0 comments
Assignees
@lgeretti
Labels
deficiency Un undesirable feature which is not a bug dynamics Dynamics module
Milestone
Fix bugs

Comments

@lgeretti
Copy link
Member

lgeretti commented May 2, 2021

According to Clang-tidy, setting a default on override methods is prohibited. Hence we shall not force orbit to any particular default semantics. To be explicit in this sense is also preferable in my opinion.
@lgeretti lgeretti added dynamics Dynamics module deficiency Un undesirable feature which is not a bug labels May 2, 2021
@lgeretti lgeretti added this to the Fix bugs milestone May 2, 2021
@lgeretti lgeretti self-assigned this May 2, 2021
lgeretti added a commit that referenced this issue May 3, 2021
@lgeretti
Remove default upper semantics for orbit methods (solves #556)
f53809d
@lgeretti lgeretti closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgeretti lgeretti

Labels
deficiency Un undesirable feature which is not a bug dynamics Dynamics module
Milestone
Fix bugs
Development

No branches or pull requests
1 participant
@lgeretti