Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks bad #49

Closed
Sgiath opened this issue Feb 3, 2015 · 8 comments
Closed

Looks bad #49

Sgiath opened this issue Feb 3, 2015 · 8 comments

Comments

@Sgiath
Copy link
Contributor

Sgiath commented Feb 3, 2015

Hi, why my Terminal with git repository looks so bad? (arrow at the end of "git line"). Is it just because I've changed colors in my profile or there is some way how to fix it?
oh-my-git

Thanks

@arialdomartini
Copy link
Owner

Hi @Sgiath
Yes, it depends on the background color.
I'm working on a fix, which I will document in the readme. Stay tuned, I'll be pushing it in few hours.

arialdomartini added a commit that referenced this issue Feb 4, 2015
@arialdomartini
Copy link
Owner

Hi @Sgiath
The issue should be fixed. Please find a detailed description in the readme.
I hope this helps!

@Sgiath
Copy link
Contributor Author

Sgiath commented Feb 4, 2015

I have better fix for that :)
oh-my-git
In color palette set the first color (top-left corner) same as background color and this fix it ;)

@arialdomartini
Copy link
Owner

Great!
I'm adding this to te readme.

Anyway, this works as long as the background is taken from the 16 colors palette. With OS X Terminal, thou, the background can be choosed from a 16M palette, and this makes the problem harder.

(Edit: apparently I misurderstood your solution)

I'm adding your solution in the documentation. Thanks, @Sgiath !

@krayon
Copy link

krayon commented Feb 12, 2017

@arialdomartini

I'm SURE I've missed something, but is there any reason you wouldn't just reset then set foreground to red again?

This appears to have the desired affect to me:
https://github.com/krayon/oh-my-git/tree/lastcharfix

@arialdomartini
Copy link
Owner

Ciao @krayon.
does it work with any background color? If so, I'll be happy to merge a pull request of yours!

@krayon
Copy link

krayon commented Apr 12, 2017

@arialdomartini Sorry I missed your reply. It does work for me with any background colour in urxvt but I've not tried it in anything else. My only hesitation is that it seemed so obvious I assume there must be a reason no one else offered up the solution :S

EDIT: I just tested in suckless terminal and it also works there.
EDIT2: Also works in cool-retro-term

@krayon
Copy link

krayon commented Apr 12, 2017

@arialdomartini As requested, I have created a PR ( #108 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants