Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed, Fixes #7

Merged
merged 13 commits into from
Nov 8, 2013
Merged

Speed, Fixes #7

merged 13 commits into from
Nov 8, 2013

Conversation

lvivski
Copy link
Contributor

@lvivski lvivski commented Nov 8, 2013

There's a lot of changes and tweaks. I'll add comments to the code

@@ -1,41 +1,41 @@
# Symbols
: ${is_a_git_repo_symbol:="❤"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple strings without variables now use single quotes

@lvivski
Copy link
Contributor Author

lvivski commented Nov 8, 2013

If you want to test it before merging you can take it from here https://github.com/lvivski/oh-my-git

@arialdomartini
Copy link
Owner

Excellent

arialdomartini added a commit that referenced this pull request Nov 8, 2013
@arialdomartini arialdomartini merged commit 519aef3 into arialdomartini:master Nov 8, 2013
@arialdomartini
Copy link
Owner

If you want to test it before merging you can take it from here https://github.com/lvivski/oh-my-git
Yes, thanks! I did add your repo as a remote days ago.

I always pull from your repo before merging, and I review each of your commits.
But I could accept your pull request with my eyes closed: your code quality is systematically excellent.

@lvivski
Copy link
Contributor Author

lvivski commented Nov 8, 2013

Well, review is always a good thing. I can miss something, or have a typo etc

compholio pushed a commit to compholio/oh-my-git that referenced this pull request Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants