-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week picker and fix for issue #116 #161
Conversation
Thank you for this pull request! Nice work you put into this. Could you please use the MooTools code style like https://github.com/mootools/mootools-core/wiki/Syntax-and-Coding-Style-Conventions Basically not breaking line before a I didn't manage to look at all the code and funcionality. But just wanted to give some feedback this far. |
Indeed, please use the code style that is used elsewhere throughout the code, in this case tabs and what @SergioCrisostomo mentions. Also, separate pull requests for different fixes would be much appreciated, so a separate pull request for the fix for #116. With git, you could create a new branch, git-rebase or git-cherry pick the right commits. |
You are totally right. I'll fix this. Do I have to close this pull request or can I modify it after fixing this? |
As you used your master branch, it's better to create a new, clean, branch, get the right commits, fix the coding style, and open a new pull request. |
You are sending this pull request from your master branch, you could make one branch for each change and send the pull request from there. You can then close this one by including |
(sorry for double posting, @arian was faster answering and I missed that 😄 ) |
Thanks. (No problem @SergioCrisostomo 😄) Sorry for all this confusion. The fix for #116 conflicts with the weekpicker and so I will send an pull request after the PR #162 is accepted. |
Added an option for to use a week picker instead of day picker.
Also added an fix for issue #116 from.