Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing and evaluating of first monday of august #205

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Conversation

Ari24-cb24
Copy link
Member

@Ari24-cb24 Ari24-cb24 commented Mar 28, 2023

Description about the changes

First monday of august should be considered an absolute preposition but it never got parsed in the first place. This pull requests adds the missing functionality to add this grammar.

Closes #198

Testcases that have been added

  • second monday of august 2023: Expected(year=2023, month=8, day=7)

Python Version you tested this feature on

  • Python 3.7
  • Python 3.8
  • Python 3.9
  • Python 3.10
  • Python 3.11

@Ari24-cb24 Ari24-cb24 added parser Used for any kinds of issues with the parser evaluator Used for any kinds of issues with the evaluator parser-grammar Used for any kinds of issues with parser-grammar evaluator-grammar Used for any kinds of issues with evaluator-grammar labels Mar 28, 2023
@Ari24-cb24 Ari24-cb24 added this to the Production Ready milestone Mar 28, 2023
@Ari24-cb24 Ari24-cb24 marked this pull request as draft March 28, 2023 14:17
@Ari24-cb24 Ari24-cb24 linked an issue Mar 28, 2023 that may be closed by this pull request
@Ari24-cb24 Ari24-cb24 marked this pull request as ready for review March 30, 2023 16:31
@Ari24-cb24 Ari24-cb24 changed the title WIP: Added parsing and evaluating of first monday of august Added parsing and evaluating of first monday of august Mar 30, 2023
@Ari24-cb24 Ari24-cb24 merged commit 6e49149 into dev Apr 3, 2023
@Ari24-cb24 Ari24-cb24 deleted the #198/dev branch April 3, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluator Used for any kinds of issues with the evaluator evaluator-grammar Used for any kinds of issues with evaluator-grammar parser Used for any kinds of issues with the parser parser-grammar Used for any kinds of issues with parser-grammar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Missing Parser grammar] First monday of august
1 participant