Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams page #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Teams page #6

wants to merge 1 commit into from

Conversation

paaban25
Copy link

@paaban25 paaban25 commented Aug 24, 2023

fix #2

@pranav-iitr pranav-iitr self-requested a review August 24, 2023 09:09
Copy link
Contributor

@pranav-iitr pranav-iitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash all commits into 1
follow proper naming conventions like [feat] made frontend of teams page types

@@ -22,4 +22,5 @@
urlpatterns = [
path('admin/', admin.site.urls),
path('user/', include(user_urls)),
path('alum/',include(alum_urls))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend chages undo kardo

frontend/components/Card.tsx Outdated Show resolved Hide resolved
frontend/package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
// import MemberList from './MemberList';

const OurTeam = () => {
const styleObj = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style obj ko cs files me likho
try ki only jo cheez tailwind se feesaible nahi ho rahi unhe hi alag se likho

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssare css tailwind classes me add kardi!!!


const OurTeam = () => {
const styleObj = {
background: ";",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use of this line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 12???
no use ...
resolved by give tailwnd classes

</div>
<div className="mt-5 m-auto block text-center overflow-y-scroll scroll-smooth scrollbar-thin h-[66vh] w-[75%] pl-[2%] pt-[1%] flex flex-row flex-wrap overflow-hidden">

{ members.map((member,it)=>{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format karo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format means indentation??

frontend/components/Card.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

team page
2 participants