atlasmigration: store migrations.tar.gz in k8s' secrets

[giautm]

No description provided.

[rotemtam]

Shouldn't we delete the previous version of the secret?

Also should secrets be deleted when the migration resource is deleted ?

[giautm]

Also should secrets be deleted when the migration resource is deleted ?

Absolute yes.

Shouldn't we delete the previous version of the secret?

I'm not sure when we need to delete the old version, because if we keep only single version, we only need to delete it when the migration resource was deleted.

If we store more than one version, we may delete the old one when a new deployment was success. But, what if the latest deployment is a migrate down - (with Aborted status?!) ? Or chain of migrate downs?

[rotemtam]

Chain of down migrations is an interesting use case.
If you store that migration dir at the version, after the migrate down is done, I think that it will be OK.

E.g:
User deploys v3 - dir(1,2,3) is stored
The user asks to go down to v2
Down migration applied - dir(1,2) is stored
The user asks to go down to v1
Down migration applied dir(1) is stored.

Re: failed down migration, or aborted down migration, you never replace the stored state, since the state is still the version before you rolled back.

Sounds OK ?

[giautm]

failed down migration, or aborted down migration, you never replace the stored state, since the state is still the version before you rolled back.

This need to be check/update to expected in the PR #167; for now, we just save the dir-state after successful reconcile, whatever flow it did.