Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add username and host from secret #90

Merged
merged 3 commits into from
Sep 11, 2023
Merged

api: add username and host from secret #90

merged 3 commits into from
Sep 11, 2023

Conversation

datdao
Copy link
Member

@datdao datdao commented Sep 7, 2023

@datdao datdao requested review from rotemtam and giautm September 7, 2023 04:27
rotemtam
rotemtam reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we reuse the same struct for UserFrom, PasswordFrom etc?
  2. Please add tests

@datdao datdao requested a review from rotemtam September 7, 2023 17:03
@datdao datdao merged commit 61e88e9 into master Sep 11, 2023
@datdao datdao deleted the feat/atlas-issue-2051 branch September 11, 2023 02:59
@datdao datdao mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam approved these changes

@giautm giautm Awaiting requested review from giautm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datdao @rotemtam