Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: support disposeDevDB flag #91

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

datdao
Copy link
Member

@datdao datdao commented Sep 12, 2023

Issues: ariga/atlas#2051
Support flag prewarmDevDB to configure the lifecycle of the devdb. You can enable this configuration through helm install to keep the devdb running after the schema has been applied. By default, the flag will be set to true

@datdao datdao requested review from rotemtam and giautm September 12, 2023 11:57
@datdao datdao force-pushed the feat/atlas-issue-2051 branch from 944dbf6 to 1de1750 Compare September 12, 2023 12:32
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, I prefer this setting is opt out rather than opt in (i.e have a warm dev db by default).

@datdao datdao force-pushed the feat/atlas-issue-2051 branch from 3dadceb to 09a8748 Compare September 12, 2023 17:41
@datdao datdao changed the title controllers: support keepDevDB flag controllers: support disposeDevDB flag Sep 12, 2023
@datdao datdao force-pushed the feat/atlas-issue-2051 branch from 09a8748 to 6dbb3bd Compare September 12, 2023 18:29
@datdao datdao requested a review from rotemtam September 13, 2023 07:58
controllers/devdb.go Outdated Show resolved Hide resolved
@datdao datdao force-pushed the feat/atlas-issue-2051 branch from bd574ec to e089bbc Compare September 14, 2023 13:23
@datdao datdao merged commit c4334e5 into master Sep 18, 2023
1 check passed
@datdao datdao deleted the feat/atlas-issue-2051 branch September 18, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants