api: remove special characters from url #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
reviewed
Oct 2, 2023
api/v1alpha1/target.go
Outdated
| @@ -96,25 +97,26 @@ func (s TargetSpec) DatabaseURL(ctx context.Context, r client.Reader, ns string) | |||
|
|
|||
| // URL returns the URL for the database. | |||
| func (c *Credentials) URL() *url.URL { | |||
| r := regexp.MustCompile("\t|\n|\r") | |||
There was a problem hiding this comment.
move to out of this function
Suggested change
| r := regexp.MustCompile("\t|\n|\r") | |
| r := regexp.MustCompile("[\t\r\n]") |
datdao
force-pushed
the
fix/remove-special-characters
branch
2 times, most recently
from
f1717ef to
ffa2ac0
Compare
giautm
reviewed
Oct 2, 2023
controllers/common.go
Outdated
| return r.ReplaceAllString(v, "") | ||
| } | ||
| if v, ok := s.(interface { | ||
| String() string |
controllers/common.go
Outdated
| @@ -58,6 +59,18 @@ var ( | |||
| b.WriteRune(']') | |||
| return b.String() | |||
| }, | |||
| "removeSpecialChars": func(s interface{}) string { | |||
datdao
force-pushed
the
fix/remove-special-characters
branch
from
ffa2ac0 to
2b8c226
Compare
giautm
approved these changes
Oct 2, 2023
giautm
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.