-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema/inspect: support inspect for non-database resource #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
giautm
force-pushed
the
g/inspect-files-url
branch
from
April 13, 2023 16:56
cf165cc
to
bb525a1
Compare
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
masseelch
reviewed
Apr 14, 2023
masseelch
reviewed
Apr 14, 2023
masseelch
reviewed
Apr 14, 2023
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
giautm
force-pushed
the
g/inspect-files-url
branch
from
April 14, 2023 08:23
a5e4db2
to
0d53d61
Compare
a8m
reviewed
Apr 14, 2023
a8m
reviewed
Apr 14, 2023
giautm
changed the title
cmdapi: support stateLoaders on
schema/inspect: support inspect for non-database resource
Apr 14, 2023
schema inspect
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
giautm
force-pushed
the
g/inspect-files-url
branch
from
April 14, 2023 11:24
6c16018
to
8bd8c80
Compare
masseelch
approved these changes
Apr 14, 2023
I will wait for @a8m stamp. |
a8m
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but see my only comment there.
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
Signed-off-by: Giau. Tran Minh <hello@giautm.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
atlas schema inspect
command to support other resources: sql-file, hcl-file, and Ent's schema. When you do inspect those resources, you need to provide a dev-DB for Atlas to replay changes on it.With an unexpected side effect, to fix what we believe to be a bug with the inspect command. The
--exclude
flag when used with schema connection can only exclude sub-resources such as: table, column, index, ... and no longer exclude the current schema.Those commands are invalid
Need to update to this:
For connection to realm, the exclude flag doesn't affect by this PR. So the bellow command still working fine.
atlas schema inspect -u "mysql://user:pass@localhost:3306" --exclude=dbname