Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/sqlite: extract table options (without rowid, strict) from sql #1745

Merged
merged 5 commits into from
Jun 19, 2023
Merged

sql/sqlite: extract table options (without rowid, strict) from sql #1745

merged 5 commits into from
Jun 19, 2023

Conversation

noamcattan
Copy link
Member

No description provided.

@noamcattan noamcattan requested review from a8m and masseelch June 15, 2023 07:11
a8m
a8m reviewed Jun 15, 2023
View reviewed changes
sql/sqlite/inspect.go Outdated Show resolved Hide resolved
a8m
a8m requested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about using the standard information schema for this.

@noamcattan noamcattan force-pushed the sqlite-table_options branch 4 times, most recently from 62ad10b to 2220eea Compare June 15, 2023 10:52
@noamcattan noamcattan requested a review from a8m June 15, 2023 10:55
a8m
a8m reviewed Jun 15, 2023
View reviewed changes
sql/sqlite/inspect.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Jun 15, 2023
View reviewed changes
sql/sqlite/sqlspec.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Jun 15, 2023
View reviewed changes
sql/sqlite/inspect.go Outdated Show resolved Hide resolved
@noamcattan noamcattan force-pushed the sqlite-table_options branch 2 times, most recently from 569d366 to 5648a6c Compare June 18, 2023 08:37
a8m
a8m reviewed Jun 18, 2023
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See minor comments

sql/sqlite/inspect_test.go Outdated Show resolved Hide resolved
sql/sqlite/inspect.go Outdated Show resolved Hide resolved
@a8m
Copy link
Member

a8m commented Jun 19, 2023

Please rebase this branch.

a8m
a8m reviewed Jun 19, 2023
View reviewed changes
sql/sqlite/inspect_test.go Outdated Show resolved Hide resolved
a8m
a8m approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@a8m a8m merged commit b2b2e80 into master Jun 19, 2023
@a8m a8m deleted the sqlite-table_options branch June 19, 2023 08:50
This was referenced Aug 6, 2023
Closed
Open
This was referenced Aug 6, 2023
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Nov 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

@masseelch masseelch Awaiting requested review from masseelch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamcattan @a8m