Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libsql+file:// support #2203

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Add libsql+file:// support #2203

merged 4 commits into from
Nov 21, 2023

Conversation

haaawk
Copy link
Contributor

@haaawk haaawk commented Oct 23, 2023

Fixes #2198

@haaawk
Add libsql+file:// support
3ecbe34 
Fixes ariga#2198

Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
@haaawk haaawk mentioned this pull request Oct 23, 2023
Closed
a8m
a8m reviewed Oct 23, 2023
View reviewed changes
sql/sqlite/driver.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Oct 23, 2023
View reviewed changes
sql/sqlite/driver.go Outdated Show resolved Hide resolved
haaawk and others added 2 commits October 23, 2023 12:24
@haaawk @a8m
Update sql/sqlite/driver.go
8fb44d1 
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
@haaawk @a8m
Update sql/sqlite/driver.go
ef8fd72 
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
@haaawk haaawk requested a review from a8m October 23, 2023 10:26
@a8m
Copy link
Member

a8m commented Oct 23, 2023 •
edited
Loading

CI is failing due to GitHub Actions issues go proxy issue. I'll rerun this soon

giautm
giautm reviewed Nov 21, 2023
View reviewed changes
sql/sqlite/driver.go Outdated Show resolved Hide resolved
@haaawk
Copy link
Contributor Author

haaawk commented Nov 21, 2023

Thanks @giautm

@giautm giautm merged commit cfac114 into ariga:master Nov 21, 2023
23 checks passed
@giautm
Copy link
Member

giautm commented Nov 21, 2023

Thank you for your contribution @haaawk,

@BrewTestBot BrewTestBot mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giautm giautm giautm approved these changes

@a8m a8m Awaiting requested review from a8m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't connect to LibSQL local file database
3 participants
@haaawk @a8m @giautm