Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/md: clickhouse guide #2487

Merged
merged 6 commits into from
Jan 31, 2024
Merged

doc/md: clickhouse guide #2487

merged 6 commits into from
Jan 31, 2024

Conversation

hilakashai
Copy link
Contributor

No description provided.

@giautm giautm requested a review from datdao January 30, 2024 15:05
@giautm
Copy link
Member

giautm commented Jan 30, 2024

@hilakashai: There is a broken link.

Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.

Exhaustive list of all broken links found:

- On source page path = /guides/clickhouse/getting-started:
   -> linking to /docs

rotemtam
rotemtam reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, see comments

doc/md/guides/clickhouse/getting-started.mdx Outdated Show resolved Hide resolved
doc/md/guides/clickhouse/getting-started.mdx Outdated Show resolved Hide resolved
doc/md/guides/clickhouse/getting-started.mdx Outdated Show resolved Hide resolved
doc/md/guides/clickhouse/getting-started.mdx Outdated Show resolved Hide resolved
doc/md/guides/clickhouse/getting-started.mdx Outdated Show resolved Hide resolved
doc/md/guides/clickhouse/getting-started.mdx Outdated Show resolved Hide resolved
rotemtam
rotemtam reviewed Jan 31, 2024
View reviewed changes
doc/md/guides/clickhouse/clickhouse.mdx Outdated
To create the table above on our local database, we can run the following command:

```sql
docker exec -it atlas-demo clickhouse-client --query 'CREATE TABLE demo.users (id UInt64, name String NOT NULL, PRIMARY KEY (id)) ENGINE = MergeTree() ORDER BY id'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rotemtam rotemtam changed the title doc/md: ClickHouse Guide doc/md: clickHouse guide Jan 31, 2024
@rotemtam rotemtam changed the title doc/md: clickHouse guide doc/md: clickhouse guide Jan 31, 2024
rotemtam
rotemtam approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hilakashai hilakashai merged commit fda4333 into master Jan 31, 2024
2 checks passed
@hilakashai hilakashai deleted the clickhouse-doc branch January 31, 2024 15:38
@BrewTestBot BrewTestBot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam approved these changes

@a8m a8m Awaiting requested review from a8m

@giautm giautm Awaiting requested review from giautm

@masseelch masseelch Awaiting requested review from masseelch

@datdao datdao Awaiting requested review from datdao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hilakashai @giautm @rotemtam